New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PlaylistItem use Paragraphs #808

Merged
merged 7 commits into from May 20, 2017

Conversation

2 participants
@DrabWeb
Contributor

DrabWeb commented May 20, 2017

No description provided.

Show outdated Hide outdated osu.Game/Overlays/Music/PlaylistItem.cs
var t = new List<SpriteText>();
//space after the title to put a space between the title and artist
text.AddText(titleBind.Value + @" ", sprite =>

This comment has been minimized.

@peppy

peppy May 20, 2017

Member

shall we make AddText return IEnumerable<Sprite>?

@peppy

peppy May 20, 2017

Member

shall we make AddText return IEnumerable<Sprite>?

This comment has been minimized.

@DrabWeb

DrabWeb May 20, 2017

Contributor

Sure I'll open a PR on the framework in a minute

@DrabWeb

DrabWeb May 20, 2017

Contributor

Sure I'll open a PR on the framework in a minute

@peppy

peppy approved these changes May 20, 2017

@peppy peppy merged commit 82f2927 into ppy:master May 20, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment