New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out SectionsContainer from Settings #815

Merged
merged 20 commits into from May 22, 2017

Conversation

2 participants
@huoyaoyuan
Contributor

huoyaoyuan commented May 20, 2017

This is the preparation for user page. It's sharing the scroll and navigate pattern with Settings, so I make a general container for it.
SettingsOverlay should work as before now.
not sure about the namespace for it

@peppy peppy changed the title from Abstract a SectionsContainer to Abstract out SectionsContainer from Settings May 22, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy May 22, 2017

Member

Great job on this, can't spot any immediate issues.

Member

peppy commented May 22, 2017

Great job on this, can't spot any immediate issues.

@peppy

peppy approved these changes May 22, 2017

@peppy peppy merged commit 9d411fe into ppy:master May 22, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@huoyaoyuan huoyaoyuan deleted the huoyaoyuan:sections branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment