Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spinner colours #817

Merged
merged 4 commits into from May 22, 2017

Conversation

2 participants
@peppy
Copy link
Member

commented May 21, 2017

Still may require a few more tweaks, but feeling a lot better already.

@peppy peppy force-pushed the peppy:spinner-colour-rehash branch from b1dc7e1 to 8f3ab79 May 21, 2017

Radius = 20,
Colour = glowColour,
Radius = 10,
Colour = Color4.Gray.Opacity(0.2f),

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 22, 2017

Contributor

Sure you want to do this instead of using OsuColour?

This comment has been minimized.

Copy link
@peppy

peppy May 22, 2017

Author Member

either way it's just specifying a specific colour. i'm not sure of the difference

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 22, 2017

Contributor

Makes this not skinnable by way of skinning colours.

This comment has been minimized.

Copy link
@peppy

peppy May 22, 2017

Author Member

if it was using osucolour it's just going to be using the gray generation function. which i don't think will ever be skinnable

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 22, 2017

Contributor

Or define a new SpinnerTickGlow colour like there is with SpinnerBase and SpinnerFill with the default being SpinnerTickGlow = Gray(128), or perhaps even referencing one of the existing grays, OsuColour.Gray8 is close enough imho.

This comment has been minimized.

Copy link
@peppy

peppy May 22, 2017

Author Member

if you insist, but i can guarantee the grays will never be used for skinning

This comment has been minimized.

Copy link
@peppy

peppy May 22, 2017

Author Member

actually i'm not changing it. opacity is also being applied. it's pointles

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 22, 2017

Contributor

I don't see how that changes anything, but whatever... Guess we'll change it when it inevitably comes up.

@smoogipoo smoogipoo merged commit 0ddf2cb into ppy:master May 22, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:spinner-colour-rehash branch May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.