New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User panel #825

Merged
merged 15 commits into from May 24, 2017

Conversation

3 participants
@DrabWeb
Contributor

DrabWeb commented May 22, 2017

screen shot 2017-05-22 at 3 27 23 am

Replaces #725
Resolves #844

Show outdated Hide outdated osu.Game/Users/UserStatus.cs
public abstract class UserStatus
{
public abstract string Message { get; }
public abstract Color4 Colour(OsuColour colours);

This comment has been minimized.

@peppy

peppy May 22, 2017

Member

GetAppropriateColour maybe.

@peppy

peppy May 22, 2017

Member

GetAppropriateColour maybe.

Show outdated Hide outdated osu.Game/Users/UserPanel.cs
{
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
Texture = textures.Get(user.CoverUrl),

This comment has been minimized.

@peppy

peppy May 22, 2017

Member

same issue here. this isn't being async'd

@peppy

peppy May 22, 2017

Member

same issue here. this isn't being async'd

Show outdated Hide outdated osu.Game/Users/UserPanel.cs
private void displayStatus(UserStatus status)
{
statusBg.FadeColour(status.Colour(colours), 200);

This comment has been minimized.

@peppy

peppy May 22, 2017

Member

, 500, EasingTypes.OutQuint); looks a bit smoother

@peppy

peppy May 22, 2017

Member

, 500, EasingTypes.OutQuint); looks a bit smoother

@Naeferith

This comment has been minimized.

Show comment
Hide comment
@Naeferith

Naeferith May 22, 2017

Contributor

@DrabWeb : Do I need to close #725 ?

Contributor

Naeferith commented May 22, 2017

@DrabWeb : Do I need to close #725 ?

Show outdated Hide outdated osu.Game/Users/UserPanel.cs
private void displayStatus(UserStatus status)
{
statusBar.ResizeHeightTo(status == null ? 0f : status_height, 500, EasingTypes.OutQuint);

This comment has been minimized.

@peppy

peppy May 24, 2017

Member

const float transition_duration = 500;

also i'd consider splitting this out into

if (status == null)
{
    ...
}
else
{
    ...
}

to avoid all the `status==null` checks
@peppy

peppy May 24, 2017

Member

const float transition_duration = 500;

also i'd consider splitting this out into

if (status == null)
{
    ...
}
else
{
    ...
}

to avoid all the `status==null` checks
@peppy

peppy approved these changes May 24, 2017

@peppy peppy merged commit 8945b38 into ppy:master May 24, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment