New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mania holdnote input #850

Merged
merged 25 commits into from May 29, 2017

Conversation

2 participants
@smoogipoo
Contributor

smoogipoo commented May 24, 2017

Not the final design (obviously).

Going forward I want holds to:

  • Have two judgements, one for the initial hit and one for the release. The release judgement will be slightly lenient to take away from the awkwardness of both releasing and pressing other columns.
  • Have ticks give some bonus score, awarded if the player has passed through the tick whilst holding the hold note. "Missing" a tick doesn't give a miss judgement so as to not count as a miss and show a miss judgement later on.

For now the ticks are between the GREAT timing windows on both sides of the hold note. We may want to adjust this, but I think it's okay for now and will only impact hits that would otherwise have gotten GOODs on both sides.

Here's a list of input scenarios which I've considered:

  1. Pressing early enough that the head doesn't judge, and holding.
    • Nothing should judge.
  2. Pressing early enough that the head doesn't judge, holding, releasing on the tail.
    • Nothing should judge.
  3. Pressing early enough that the head doesn't judge, holding, releasing in the middle of the hold note, releasing on the tail.
    • Only ticks since the press and the tail should judge.
  4. Pressing the head, immediately releasing.
    • Only the head should judge.
  5. Pressing the head, releasing in the middle of the hold note.
    • Only the head and the ticks until the release should judge.
  6. Pressing the head, releasing on the tail.
    • Everything should judge.
  7. Pressing late enough that the head doesn't judge, holding, releasing before the tail.
    • Only the ticks during the hold should judge.
  8. Pressing late enough that the head doesn't judge, holding, releasing on the tail.
    • Only the ticks since the press and the tail should judge.
@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo May 26, 2017

Contributor

Added prereq.

Contributor

smoogipoo commented May 26, 2017

Added prereq.

@peppy

peppy approved these changes May 29, 2017

@peppy peppy merged commit 0fd0537 into ppy:master May 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo referenced this pull request May 29, 2017

Closed

Mania hold notes #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment