New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialize beatmap change animation of the music controller #856

Merged
merged 6 commits into from May 29, 2017

Conversation

3 participants
@MrTheMake
Contributor

MrTheMake commented May 25, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy May 26, 2017

Member

Can you please add a description to the PR explaining what this achieves? The title alone doesn't make it clear so I don't know what I'm looking at visually.

Member

peppy commented May 26, 2017

Can you please add a description to the PR explaining what this achieves? The title alone doesn't make it clear so I don't know what I'm looking at visually.

@MrTheMake

This comment has been minimized.

Show comment
Hide comment
@MrTheMake

MrTheMake May 26, 2017

Contributor

Yes, of course, sorry. The music controller transforms a visual beatmap change upon open it for the first time. As there was no beatmap before, that doesn't make sense designwise.

Contributor

MrTheMake commented May 26, 2017

Yes, of course, sorry. The music controller transforms a visual beatmap change upon open it for the first time. As there was no beatmap before, that doesn't make sense designwise.

@MrTheMake

This comment has been minimized.

Show comment
Hide comment
@MrTheMake

MrTheMake May 26, 2017

Contributor

Added videos of the change

Contributor

MrTheMake commented May 26, 2017

Added videos of the change

@RemieRichards

This comment has been minimized.

Show comment
Hide comment
@RemieRichards

RemieRichards May 26, 2017

Contributor

That's the same video twice.

Contributor

RemieRichards commented May 26, 2017

That's the same video twice.

@MrTheMake

This comment has been minimized.

Show comment
Hide comment
@MrTheMake

MrTheMake May 26, 2017

Contributor

Whoops. Updated second video.

Contributor

MrTheMake commented May 26, 2017

Whoops. Updated second video.

@peppy

peppy approved these changes May 29, 2017

@peppy peppy merged commit 06349c5 into ppy:master May 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@MrTheMake MrTheMake deleted the MrTheMake:musiccontroller-init-fix branch May 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment