New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social browser #859

Merged
merged 35 commits into from Jun 7, 2017

Conversation

2 participants
@DrabWeb
Contributor

DrabWeb commented May 26, 2017

screen shot 2017-05-26 at 2 57 09 am

Also refactors most of DirectOverlay's layout into a base SearchableListOverlay for direct and social

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy
Member

peppy commented May 29, 2017

namespace osu.Game.Overlays.Social
{
public class Header : SearchableListHeader<SocialTab>

This comment has been minimized.

@peppy

peppy May 31, 2017

Member

might be worth nesting this class inside SocialOverlay. i tend to prefer nesting generic-named classes like Header where possible.

@peppy

peppy May 31, 2017

Member

might be worth nesting this class inside SocialOverlay. i tend to prefer nesting generic-named classes like Header where possible.

This comment has been minimized.

@DrabWeb

DrabWeb Jun 1, 2017

Contributor

Just SocialOverlay's header, or both header and filter control? And should the same be done for DirectOverlay?

@DrabWeb

DrabWeb Jun 1, 2017

Contributor

Just SocialOverlay's header, or both header and filter control? And should the same be done for DirectOverlay?

@peppy

peppy approved these changes Jun 7, 2017

@peppy peppy merged commit 0198e16 into ppy:master Jun 7, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment