New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel selection overlay #861

Merged
merged 52 commits into from Jun 5, 2017

Conversation

2 participants
@DrabWeb
Contributor

DrabWeb commented May 26, 2017

screen shot 2017-05-26 at 3 52 19 am

Only supports joining at the moment

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy May 29, 2017

Member

As discussed in discord, we need to make this hidden by default. Let's also make it stretch to take up all available space for the time being. If the chat area is resized to the point the channel selector becomes useless (ie. it can't display 5 channels or so) then it should automatically close.

Member

peppy commented May 29, 2017

As discussed in discord, we need to make this hidden by default. Let's also make it stretch to take up all available space for the time being. If the chat area is resized to the point the channel selector becomes useless (ie. it can't display 5 channels or so) then it should automatically close.

@peppy

as mentioned

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 2, 2017

Member
  • Was it always possible to see the channel overlay appearing behind the semi-transparent tab bar? we need to fix that.
  • The tab should probably change state visually when toggled on
Member

peppy commented Jun 2, 2017

  • Was it always possible to see the channel overlay appearing behind the semi-transparent tab bar? we need to fix that.
  • The tab should probably change state visually when toggled on
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 2, 2017

Member

Opening channel select then hitting escape doesn't restore the state of the button :(

windows_10

Member

peppy commented Jun 2, 2017

Opening channel select then hitting escape doesn't restore the state of the button :(

windows_10

Fix toggle not toggling on pressing escape
Also add comment about hacky implementation of toggle tab.
@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 5, 2017

Member

I'm merging this in under the premise that I intend to fix the add-new tab this week, by adding a new ToggleableTab type and avoiding the hacky implementation.

Member

peppy commented Jun 5, 2017

I'm merging this in under the premise that I intend to fix the add-new tab this week, by adding a new ToggleableTab type and avoiding the hacky implementation.

@peppy peppy dismissed their stale review via d9106c4 Jun 5, 2017

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 5, 2017

Member

Remaining issue: Clicking channel tabs while the selection overlay is open causes no updates. May be a regression from my changes, needs further investigation.

Member

peppy commented Jun 5, 2017

Remaining issue: Clicking channel tabs while the selection overlay is open causes no updates. May be a regression from my changes, needs further investigation.

@peppy

peppy approved these changes Jun 5, 2017

@peppy peppy merged commit 2fbad58 into ppy:master Jun 5, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy referenced this pull request Aug 21, 2017

Closed

Channel selection popup #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment