New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for variables in storyboards #866

Merged
merged 11 commits into from May 31, 2017

Conversation

3 participants
@ColdVolcano
Contributor

ColdVolcano commented May 27, 2017

No description provided.

@smoogipoo

This comment has been minimized.

Show comment
Hide comment
@smoogipoo

smoogipoo May 30, 2017

Contributor

@peppy please re-review/approve.

Contributor

smoogipoo commented May 30, 2017

@peppy please re-review/approve.

}
private void handleGeneral(Beatmap beatmap, string key, string val)

This comment has been minimized.

@peppy

peppy May 30, 2017

Member

val was used here for a reason (generally we avoid using value as it is a keyword in certain contexts)

@peppy

peppy May 30, 2017

Member

val was used here for a reason (generally we avoid using value as it is a keyword in certain contexts)

This comment has been minimized.

@peppy

peppy May 30, 2017

Member

even github isn't smart enough to realise it's not a keyword here:

allow_for_variables_in_storyboards_by_coldvolcano_ pull_request__866 _ppy_osu

@peppy

peppy May 30, 2017

Member

even github isn't smart enough to realise it's not a keyword here:

allow_for_variables_in_storyboards_by_coldvolcano_ pull_request__866 _ppy_osu

This comment has been minimized.

@smoogipoo

smoogipoo May 30, 2017

Contributor

Ouch :\

@smoogipoo

smoogipoo May 30, 2017

Contributor

Ouch :\

@peppy

peppy approved these changes May 31, 2017

@peppy peppy merged commit f59edd6 into ppy:master May 31, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment