Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mania judgements #873

Merged
merged 20 commits into from May 29, 2017

Conversation

2 participants
@smoogipoo
Copy link
Contributor

commented May 29, 2017

I'm sort of stabbing in the dark here and seeing how things turn out with a new algorithm separate to osu-stable. This needs more proper experimentation before rankings happen, probably founded by data based on average drain rates, etc...

Completes #709

});

// Ticks
for (int i = 0; i < ((HoldNote)obj).TotalTicks; i++)

This comment has been minimized.

Copy link
@peppy

peppy May 29, 2017

Member

this count will evaluate every loop. i'd remove TotalTicks and just figure it out locally here.

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 29, 2017

Author Contributor

That's fine, HoldNote.Ticks wraps a List and .Count() with on an IEnumerable wrapping a list source is guaranteed to be O(1).

This comment has been minimized.

Copy link
@peppy

peppy May 29, 2017

Member

you're inferring a lot there...
you're also only using TotalTicks here. so just calculate it here for now?

@@ -2,6 +2,7 @@
// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE

using System.Collections.Generic;
using System.Linq;

This comment has been minimized.

Copy link
@peppy

This comment has been minimized.

Copy link
@smoogipoo

smoogipoo May 29, 2017

Author Contributor

Hwoops.

smoogipoo and others added some commits May 29, 2017

@peppy

peppy approved these changes May 29, 2017

@peppy peppy merged commit cf540a6 into ppy:master May 29, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@smoogipoo smoogipoo deleted the smoogipoo:mania-judgements branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.