New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for toggling raw input and adjusting sensitivity #893

Merged
merged 9 commits into from Jun 5, 2017

Conversation

4 participants
@peppy
Member

peppy commented Jun 2, 2017

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 Jun 3, 2017

Contributor
  • Mouse sensitivity shouldn't change while dragging the sliderbar, but only on release.
  • Currently, left/right arrow keys change mouse sensitivity by +-0.5 which is too much imho. Also there needs to be a way (potentially via hotkey) to change it in 0.01 increments like in stable, such that people can set exact values.
Contributor

Tom94 commented Jun 3, 2017

  • Mouse sensitivity shouldn't change while dragging the sliderbar, but only on release.
  • Currently, left/right arrow keys change mouse sensitivity by +-0.5 which is too much imho. Also there needs to be a way (potentially via hotkey) to change it in 0.01 increments like in stable, such that people can set exact values.
@Tom94

As commented above.

@peppy

This comment has been minimized.

Show comment
Hide comment
@peppy

peppy Jun 3, 2017

Member

Oh yeah, those changes are obviously a must :P.

Member

peppy commented Jun 3, 2017

Oh yeah, those changes are obviously a must :P.

fixed

@Tom94

This comment has been minimized.

Show comment
Hide comment
@Tom94

Tom94 Jun 5, 2017

Contributor

There is still no way to change the value in small increments (0.01) via arrow keys, but that might be out of scope for this PR.

Contributor

Tom94 commented Jun 5, 2017

There is still no way to change the value in small increments (0.01) via arrow keys, but that might be out of scope for this PR.

rawInputToggle.TriggerChange();
}
private class SensitivitySetting : SettingsSlider<double, SensitivitySlider>

This comment has been minimized.

@Tom94

Tom94 Jun 5, 2017

Contributor

I wonder if it shouldn't be a feature of SliderBar in general to allow for delayed commits of the value.

@Tom94

Tom94 Jun 5, 2017

Contributor

I wonder if it shouldn't be a feature of SliderBar in general to allow for delayed commits of the value.

This comment has been minimized.

@peppy

peppy Jun 5, 2017

Member

we can move it if it comes up again. i couldn't think of another use case and didn't want to pollute SliderBar

@peppy

peppy Jun 5, 2017

Member

we can move it if it comes up again. i couldn't think of another use case and didn't want to pollute SliderBar

@Tom94

Tom94 approved these changes Jun 5, 2017

@Tom94 Tom94 merged commit d1508f3 into ppy:master Jun 5, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@peppy peppy deleted the peppy:raw-input-sensitivity branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment