Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃悰 add missing spinner features to the button component #38

Merged
merged 4 commits into from Jan 12, 2020

Conversation

@pqt
Copy link
Owner

pqt commented Jan 12, 2020

No description provided.

pqt added 4 commits Jan 12, 2020
this ultimately has the button behave more predictably with icons
@pqt pqt changed the title fix: 馃悰 add missing spinner features fix: 馃悰 add missing spinner features to the button component Jan 12, 2020
@pqt pqt changed the title fix: 馃悰 add missing spinner features to the button component fix: 馃悰 add missing spinner features to the button component Jan 12, 2020
@pqt pqt merged commit 9b063db into release-1.6.1 Jan 12, 2020
2 checks passed
2 checks passed
Publish to NPM & GPR
Details
publish @pqt/components 0.0.0-ebea3cd
Details
@pqt pqt deleted the fix/spinner branch Jan 12, 2020
pqt added a commit that referenced this pull request Jan 19, 2020
* fix: 馃悰 add missing spinner features to the button component (#38)

* fix: 馃悰 add missing spinner features to the button component

* refactor: 馃挕 change how spinners and buttons will interact

* refactor: 馃挕 remove unused import

* style: 馃拕 convert button from inline-flex to inline-grid

this ultimately has the button behave more predictably with icons

* v1.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.