From 0bbbf5cbedff8e99a142ea914f2bacd943e0b32c Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 19 Jun 2025 16:18:48 +0400 Subject: [PATCH 1/4] Revert "Remove random stuff" This reverts commit 7986b4de129cc0dda76c39536fc2881fc3ca904c. --- .../snapshot/get/SnapshotGetRequest.ts | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/specification/snapshot/get/SnapshotGetRequest.ts b/specification/snapshot/get/SnapshotGetRequest.ts index a3fb758f89..69875f92b6 100644 --- a/specification/snapshot/get/SnapshotGetRequest.ts +++ b/specification/snapshot/get/SnapshotGetRequest.ts @@ -128,5 +128,31 @@ export interface Request extends RequestBase { * @availability serverless */ size?: integer + /** + * Filter snapshots by a comma-separated list of snapshot lifecycle management (SLM) policy names that snapshots belong to. + * + * You can use wildcards (`*`) and combinations of wildcards followed by exclude patterns starting with `-`. + * For example, the pattern `*,-policy-a-\*` will return all snapshots except for those that were created by an SLM policy with a name starting with `policy-a-`. + * Note that the wildcard pattern `*` matches all snapshots created by an SLM policy but not those snapshots that were not created by an SLM policy. + * To include snapshots that were not created by an SLM policy, you can use the special pattern `_none` that will match all snapshots without an SLM policy. + * @availability stack since=7.16.0 + * @availability serverless + */ + slm_policy_filter?: Name + /** + * The sort order for the result. + * The default behavior is sorting by snapshot start time stamp. + * @server_default start_time + * @availability stack since=7.14.0 + * @availability serverless + */ + sort?: SnapshotSort + /** + * If `true`, returns additional information about each snapshot such as the version of Elasticsearch which took the snapshot, the start and end times of the snapshot, and the number of shards snapshotted. + * + * NOTE: The parameters `size`, `order`, `after`, `from_sort_value`, `offset`, `slm_policy_filter`, and `sort` are not supported when you set `verbose=false` and the sort order for requests with `verbose=false` is undefined. + * @server_default true + */ + verbose?: boolean } } From ae632cd3458d9c55d97ec5c443a8243ebb1a556f Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 19 Jun 2025 16:49:48 +0400 Subject: [PATCH 2/4] debug --- .github/validate-pr/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/validate-pr/index.js b/.github/validate-pr/index.js index e1bfb9d5f6..7440e4cd20 100644 --- a/.github/validate-pr/index.js +++ b/.github/validate-pr/index.js @@ -145,8 +145,10 @@ console.log(file) core.setOutput('has_results', 'true') core.setOutput('comment_body', comment) +console.log('comment!') } else { core.setOutput('has_results', 'false') +console.log('no comment!') } core.info('Done!') From e2eb55dea6847cd12a6efcb1d329a28a5261ca21 Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 19 Jun 2025 17:12:10 +0400 Subject: [PATCH 3/4] Revert "Revert "Remove random stuff"" This reverts commit 0bbbf5cbedff8e99a142ea914f2bacd943e0b32c. --- .../snapshot/get/SnapshotGetRequest.ts | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/specification/snapshot/get/SnapshotGetRequest.ts b/specification/snapshot/get/SnapshotGetRequest.ts index 69875f92b6..a3fb758f89 100644 --- a/specification/snapshot/get/SnapshotGetRequest.ts +++ b/specification/snapshot/get/SnapshotGetRequest.ts @@ -128,31 +128,5 @@ export interface Request extends RequestBase { * @availability serverless */ size?: integer - /** - * Filter snapshots by a comma-separated list of snapshot lifecycle management (SLM) policy names that snapshots belong to. - * - * You can use wildcards (`*`) and combinations of wildcards followed by exclude patterns starting with `-`. - * For example, the pattern `*,-policy-a-\*` will return all snapshots except for those that were created by an SLM policy with a name starting with `policy-a-`. - * Note that the wildcard pattern `*` matches all snapshots created by an SLM policy but not those snapshots that were not created by an SLM policy. - * To include snapshots that were not created by an SLM policy, you can use the special pattern `_none` that will match all snapshots without an SLM policy. - * @availability stack since=7.16.0 - * @availability serverless - */ - slm_policy_filter?: Name - /** - * The sort order for the result. - * The default behavior is sorting by snapshot start time stamp. - * @server_default start_time - * @availability stack since=7.14.0 - * @availability serverless - */ - sort?: SnapshotSort - /** - * If `true`, returns additional information about each snapshot such as the version of Elasticsearch which took the snapshot, the start and end times of the snapshot, and the number of shards snapshotted. - * - * NOTE: The parameters `size`, `order`, `after`, `from_sort_value`, `offset`, `slm_policy_filter`, and `sort` are not supported when you set `verbose=false` and the sort order for requests with `verbose=false` is undefined. - * @server_default true - */ - verbose?: boolean } } From 81e301fb0a05fc1f1cf1e4c90c8ec9bccab0f851 Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 19 Jun 2025 17:14:25 +0400 Subject: [PATCH 4/4] add comment --- specification/snapshot/_types/SnapshotIndexDetails.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/snapshot/_types/SnapshotIndexDetails.ts b/specification/snapshot/_types/SnapshotIndexDetails.ts index 9ea0560e08..7185a2aa8c 100644 --- a/specification/snapshot/_types/SnapshotIndexDetails.ts +++ b/specification/snapshot/_types/SnapshotIndexDetails.ts @@ -20,7 +20,7 @@ import { ByteSize } from '@_types/common' import { integer, long } from '@_types/Numeric' -// comment! +// new comment! export class IndexDetails { shard_count: integer size?: ByteSize