fallback_to_model_values normalizes original_attributes_hash
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In order to play nicely with `ActionController::Parameters`, which does not have a `with_indifferent_access`, we need to make sure to: * Call `to_h` (we are always expecting some sort of hash as `original_attributes_hash`) * Then call `with_indifferent_access`, to normalize it to indifferent access (`ActionController::Parameters#to_h` does this automatically, but if a regular hash is provided, we still need to convert it to indifferent access)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionController::Parameters, which does not have awith_indifferent_access, we need to make sure to:to_h(we are always expecting some sort of hash asoriginal_attributes_hash)with_indifferent_access, to normalize it to indifferent access (ActionController::Parameters#to_hdoes this automatically, but if a regular hash is provided, we still need to convert it to indifferent access)This closes #3