Patch replacing 'translate!' with 'map_to_absolute' #24

Closed
cassiomarques opened this Issue Feb 5, 2010 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

cassiomarques commented Feb 5, 2010

Here is the link to a commit where I replace translate! with 'map_to_absolute'.

The tests and examples seems to pass just fine.

http://github.com/cassiomarques/prawn-layout/commit/220cda17cda0eb8aca772947f3f2f488ba2e40e8

Contributor

cassiomarques commented Feb 5, 2010

Oh, sorry for the wrong formatting in the above link. At least it works :)

Owner

practicingruby commented Feb 5, 2010

Well, they run, but the lazy bounding box example shows you that your patch doesn't work. :)

But it was easy to fix. instead of translate! -> map_to_absolute, you want translate! -> map_to_absolute! as the former is not destructive.

Pushing a fix now.

Owner

practicingruby commented Feb 5, 2010

We really wanted map_to_absolute! (Closed by 8bc75c9)

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment