New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 warning messages break active controls #663

Closed
jcass77 opened this Issue Feb 9, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@jcass77

jcass77 commented Feb 9, 2018

PHP 7.2 introduces a backward-incompatible change that issues a warning when counting non-countable types.

This breaks PRADO's TCallbackPageStateTracker, preventing active controls from being updated after postbacks (and probably causing issues in a few other places as well).

It looks like one is supposed to wrap everything in an isset() validation before calling count(), from here on out.

@ctrlaltca

This comment has been minimized.

Member

ctrlaltca commented Feb 9, 2018

Searching 1023 files for "[^\$a-z_]count\s*\(" (regex)
227 matches across 90 files

It will be a long weekend :)

ctrlaltca added a commit that referenced this issue Feb 13, 2018

@ctrlaltca

This comment has been minimized.

Member

ctrlaltca commented Feb 13, 2018

So, the fix for the main issue reported is already in master. I'll keep this open until i finish reviewing the rest of the code.

@ctrlaltca

This comment has been minimized.

Member

ctrlaltca commented Mar 9, 2018

Another php 7.2 compatibility fix: 1b68861

@ctrlaltca

This comment has been minimized.

Member

ctrlaltca commented Mar 30, 2018

Now that 4.0.1 is released with the fix, I think it's time to close this ticket, too.

@ctrlaltca ctrlaltca closed this Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment