New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C# 8.0 Nullable References to squash bugs #3

Merged
merged 9 commits into from Dec 11, 2018

Conversation

Projects
None yet
1 participant
@praeclarum
Copy link
Owner

praeclarum commented Dec 7, 2018

.NET Core SDK 3.0.1 includes support for C# 8.0 with its nullable references.

These changes add the ? annotation and change some code to make everything null safe.

@praeclarum praeclarum self-assigned this Dec 9, 2018

@praeclarum praeclarum added the bug label Dec 9, 2018

praeclarum added some commits Dec 7, 2018

Annotate code with nullability
This currently errors because the parser generated files need updating.
Fix last compile errors
Will the unit tests pass?

@praeclarum praeclarum force-pushed the nonulls branch from a3ef4ba to 7dd6787 Dec 11, 2018

@praeclarum praeclarum merged commit cdd3992 into master Dec 11, 2018

2 checks passed

ci/bitrise/cfa2ebe75549e772/pr Passed - CLanguage
Details
ci/bitrise/cfa2ebe75549e772/push Passed - CLanguage
Details

@praeclarum praeclarum deleted the nonulls branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment