Support Visual Studio for Mac 2019#49
Closed
rdavisau wants to merge 7 commits into
Closed
Conversation
Collaborator
Author
|
Just to update anyone interested - it took a little longer than expected for me to hit some heavy iOS work, but I have been using this version in anger for the last few weeks and I'm happy that the performance of Continuous doesn't appear to have changed significantly with these updates. All that is outstanding is the write back of 'watch statements', which I will now look into. |
| boundDoc = doc; | ||
| if (boundDoc != null) { | ||
| boundDoc.DocumentParsed += ActiveDoc_DocumentParsed; | ||
| buffer = doc.GetContent<ITextBuffer2>(); |
There was a problem hiding this comment.
If you use ITextBuffer here instead of ITextBuffer2 it will work with both the old and the new text editor.
rdavisau
force-pushed
the
support-vsm2019
branch
from
3d84a1e to
3482d81
Compare
Collaborator
Author
|
Watch variables are now working again:
With that, this has the minimum set of changes required to make things work on 2019. But, this branch history is borked so I'll think I'll open a new PR. |
3 tasks
Collaborator
Author
|
Superseded by #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Not ready to merge!)
This PR aims to update Continuous to support Visual Studio for Mac 2019 by making the changes required to support the new editor APIs. From my initial assessment, we need to do the following:
Document.Editorproperty withITextView/ITextBuffer-based equivalentsDocument.Analysisproperty with an alternative solutionDocument.Editor-based document manipulation (used for writing back watch results)So far, the core functionality (so, everything except for watch results) is working OK. I used this guide to help identify API replacements.
I've had the work at this state for the last couple of weeks but haven't done much iOS development over that time. That will probably change next week and I'll be able to test drive this against real world projects, but I'm putting this up here in case anyone else has a need for it in the short term.
My main concern currently is about whether we are causing any additional typing latency (noting that it's also possible that the previous version was causing latency). I'm not sure that
TextBuffer.Changed(the new API I've used to detect document changes) is semantically equivalent to the oldDocument.DocumentParsed; the new API requires throttling moving processing off the main thread to work well.