Skip to content

A patch to support latest csharp-sqlite #29

Merged
merged 1 commit into from Apr 21, 2012

3 participants

@lextm
lextm commented Apr 1, 2012

Hi,

I found csharp-sqlite support broken. Therefore, I tried to fix it. A few lines were changed.

I tested locally with all existing unit test cases. Only one case failed,

SQLite.Tests.ByteArrayTest.ByteArrays

Empty byte array became null unexpectedly. Not sure if this is a sqlite-net issue or csharp-sqlite issue.

Regards,

Lex

@mattleibow

I opened a bug on csharp-sqlite 149: http://code.google.com/p/csharp-sqlite/issues/detail?id=149

Zero-length byte arrays are returned as null, unlike the C version.

@lextm
lextm commented Apr 7, 2012

Thanks a lot for finding a simpler reproducible sample. Hope csharp-sqlite guys can fix it soon.

@praeclarum
Owner

Hey guys. Thanks for the work. I'm a little confused by mattleibow's comment, is this patch good to go?

@praeclarum
Owner

Also, my big concern is that this breaks compat with a known WP7 version of csharp-sqlite. http://wp7sqlite.codeplex.com/

@mattleibow
@lextm
lextm commented Apr 20, 2012

I think it is the responsibility of wp7sqlite to be compatible with csharp-sqlite, not sqlite-net to bend for wp7sqlite. Ideas?

BTW, from what I observed from its CodePlex site, wp7sqlite has been out of date (no update in the past few months), and no longer as new as csharp-sqlite. Either its maintainers pull changes from csharp-sqlite to make it better compatible with csharp-sqlite API, or there should be a fork to replace it.

@praeclarum
Owner

In principle I agree with you about wp7sqlite, but it is the only library that works with WP7 right now. Ah, I hate breaking changes!

@mattleibow
@praeclarum
Owner

On that note...

@praeclarum praeclarum merged commit 3028b32 into praeclarum:master Apr 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.