Modifications for .NET Core #7

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@timheuer
Collaborator

Cleaned up LF. The file was also a mix of tabs/spaces, but tabs seemed to prevail more than spaces, so I tabified it all.

@praeclarum
Owner

:-) Thanks for all the changes, but can you just turn off your auto formatter? You've changed every line of code again. :-)

{ go on the same line as their statement, there is a space before ( on funcalls, etc...

Is your only change adding the calling convention? If so, I'll just add that myself and close this pull request.

@timheuer
Collaborator

WTF. What's weird is i don't see this in my source code...not sure where it is happening.

No, the calling convention is not the only change. Look for #if !NETFX_CORE statements

@timheuer timheuer closed this Mar 15, 2012
@praeclarum
Owner

To see what I'm grumbling about, look at the diff of your submit: 127bb21

You can also see it as "1,042 additions, 693 deletions".

OK, doing a manual merge :-(

@timheuer
Collaborator

If you can pull out the changes, that's cool. I'm starting over and
sticking with notepad to make the edits :-)


http://timheuer.com/blog/
twitter: @timheuer

On Thu, Mar 15, 2012 at 2:34 PM, Frank A. Krueger <
reply@reply.github.com

wrote:

To see what I'm grumbling about, look at the diff of your submit:
timheuer@127bb21

You can also see it as "1,042 additions, 693 deletions".

OK, doing a manual merge :-(


Reply to this email directly or view it on GitHub:
#7 (comment)

@praeclarum
Owner

Isn't it simply a matter of not pressing Ctrl-K,Ctrl-D in VS? :-)

Well, let me know if you do plan on submitting another revision, I don't want to duplicate effort!

@timheuer
Collaborator

I'll do another submission. I've already forked for my needs...just trying to give back :-)

@praeclarum
Owner

I really appreciate that! I had enough "fun" with #if NETFX_CORE in my own apps to deal with it here. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment