Send events to per-message event urls #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage forwarding worker
|
Ready for review. |
| ['application/json']) | ||
|
|
||
| self.assertEqual(req.method, 'POST') | ||
| self.assertEqual(body, api_from_event(self.worker.channel_id, event)) |
There was a problem hiding this comment.
Wonder if it's worthwhile writing a helper method for this request checking?
|
One very minor comment, otherwise looks good. |
|
Ready for re-review. |
|
👍 |
| from junebug.workers import MessageForwardingWorker | ||
| from junebug.channel import ( | ||
| Channel, ChannelNotFound, InvalidChannelType, MessageNotFound) | ||
| from junebug.tests.helpers import JunebugTestBase | ||
| from junebug.tests.utils import conjoin | ||
| from junebug.utils import conjoin |
There was a problem hiding this comment.
Can we combine this import with the one on line 6?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 will allow us to store the per-message event urls given to the api when sending a message. This ticket is for fetching these stored event urls in
MessageForwardingWorkerwhen we consume an event, and sending the event to the url.