parse messages from logs #241

Merged
merged 8 commits into from Apr 16, 2012

Conversation

Projects
None yet
3 participants
@smn
Member

smn commented Apr 12, 2012

original version only did SMPP output, this one parses Vumi message objects written to stdout

@ghost ghost assigned smn Apr 13, 2012

@hodgestar

This comment has been minimized.

Show comment Hide comment
@hodgestar

hodgestar Apr 13, 2012

Contributor

This needs to have develop merged in because #65 changed how options are processed a bit (and renamed a few things). The inject_message script also needs to be fixed.

Contributor

hodgestar commented Apr 13, 2012

This needs to have develop merged in because #65 changed how options are processed a bit (and renamed a few things). The inject_message script also needs to be fixed.

@hodgestar

This comment has been minimized.

Show comment Hide comment
@hodgestar

hodgestar Apr 14, 2012

Contributor

I updated the LogParser docstring but I don't know know where the 'smpp' and 'vumi' formats are expected to be encountered. Presumably 'smpp' is output by the SMPP transport? What outputs the 'vumi' format?

Other than this documentation enhancement the branch looks good to land.

Contributor

hodgestar commented Apr 14, 2012

I updated the LogParser docstring but I don't know know where the 'smpp' and 'vumi' formats are expected to be encountered. Presumably 'smpp' is output by the SMPP transport? What outputs the 'vumi' format?

Other than this documentation enhancement the branch looks good to land.

@hodgestar

This comment has been minimized.

Show comment Hide comment
@hodgestar

hodgestar Apr 16, 2012

Contributor

The string 'Inbound:' used in the 'vumi' format regex doesn't occur anywhere in the vumi code base except in parse_log_messages itself.

Contributor

hodgestar commented Apr 16, 2012

The string 'Inbound:' used in the 'vumi' format regex doesn't occur anywhere in the vumi code base except in parse_log_messages itself.

@smn

This comment has been minimized.

Show comment Hide comment
@smn

smn Apr 16, 2012

Member

Hm, you're right, its in the output of one of @jerith's campaigns dispatchers.

Member

smn commented Apr 16, 2012

Hm, you're right, its in the output of one of @jerith's campaigns dispatchers.

@hodgestar

This comment has been minimized.

Show comment Hide comment
@hodgestar

hodgestar Apr 16, 2012

Contributor

Should we perhaps not standardize on a single Inbound message logging format and then renamed the 'smpp' options to 'smpp-0.3' or something? Also, the SMPP logging line should probably be changed to '%r' % message instead of '%s'.

Contributor

hodgestar commented Apr 16, 2012

Should we perhaps not standardize on a single Inbound message logging format and then renamed the 'smpp' options to 'smpp-0.3' or something? Also, the SMPP logging line should probably be changed to '%r' % message instead of '%s'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment