From 355330a00b7db7fcef1abacdbc7ce1b4670b7868 Mon Sep 17 00:00:00 2001 From: Jeremy Thurgood Date: Thu, 31 Oct 2013 12:04:27 +0200 Subject: [PATCH] Better comments near hardcoded port numbers. --- vumi/transports/vas2nets/tests/test_failures.py | 3 ++- vumi/transports/vas2nets/tests/test_vas2nets.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/vumi/transports/vas2nets/tests/test_failures.py b/vumi/transports/vas2nets/tests/test_failures.py index fa850f6ca..b33bb1d05 100644 --- a/vumi/transports/vas2nets/tests/test_failures.py +++ b/vumi/transports/vas2nets/tests/test_failures.py @@ -163,7 +163,8 @@ def test_send_sms_noconn(self): """ A 'connection refused' error should be retried. """ - # Hope nothing's listening on this port. + # TODO: Figure out a solution that doesn't require hoping that + # nothing's listening on this port. self.worker.config['url'] = 'http://localhost:9999/' self.worker.failure_published = FailureCounter(1) diff --git a/vumi/transports/vas2nets/tests/test_vas2nets.py b/vumi/transports/vas2nets/tests/test_vas2nets.py index 85f745fcc..d8d46c7b1 100644 --- a/vumi/transports/vas2nets/tests/test_vas2nets.py +++ b/vumi/transports/vas2nets/tests/test_vas2nets.py @@ -291,7 +291,8 @@ def test_send_sms_fail(self): @inlineCallbacks def test_send_sms_noconn(self): - # Hope nothing's listening on this port. + # TODO: Figure out a solution that doesn't require hoping that + # nothing's listening on this port. self.transport.config['url'] = 'http://localhost:9999/' msg = self.make_outbound("hello") d = self.dispatch(msg)