New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate tags from regular pushes #20

Closed
marco-roy opened this Issue Sep 15, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@marco-roy

marco-roy commented Sep 15, 2015

Hey guys,

We have another small feature request: we would like to be able to tell whether a push contains commits and/or tags. Optional: even better would be to list the pushed tags and make them links. We're using the minimal verbosity level.

Before:
Push on SuchRepo by Very Quality <very@quality.com>. See commit list.

After:
Push on SuchRepo by Very Quality <very@quality.com> (1 commit, 1 tag: 1.4.3). See commit list.
Push on SuchRepo by Very Quality <very@quality.com> (3 tags: 1.5.6, 1.5.7, 1.5.8). See commit list.

Issue #19 's "alternate" example would also meet what we need.

Let me know what you think. :)

taxilian added a commit to gradecam/stash2slack that referenced this issue Sep 18, 2015

Refactor the push listener to add a lot of flexibility
- Fixes pragbits#19 - adds commit count
- Fixes pragbits#20 - Differentiates tag pushes
- Adds links in other parts of the messages
- Reformats commit hashes on compact mode to make messages left aligned
- Fixes links for branches to go to the correct branch
- Add the project name to the repo name in messages
- Combine all messages into one attachment to allow slack's auto collapse features to work (compact mode only)

taxilian added a commit to gradecam/stash2slack that referenced this issue Sep 18, 2015

Refactor the push listener to add a lot of flexibility
- Fixes pragbits#19 - adds commit count
- Fixes pragbits#20 - Differentiates tag pushes
- Adds links in other parts of the messages
- Reformats commit hashes on compact mode to make messages left aligned
- Fixes links for branches to go to the correct branch
- Add the project name to the repo name in messages
- Combine all messages into one attachment to allow slack's auto collapse features to work (compact mode only)

@pragbits pragbits closed this in #21 Sep 21, 2015

dszabo added a commit that referenced this issue Sep 21, 2015

Merge branch 'feature/taxilian'
Fix #19, #20, and a bunch of related cleanups and improvements to push hook #21
Implemented #17
@marco-roy

This comment has been minimized.

marco-roy commented Sep 25, 2015

Thanks guys, this is awesome!

What pushing tags looks like now:

Tag 1.0.5 pushed on VeryRepo. See commit list.
Tag 1.0.4 deleted from repository VeryRepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment