New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a new branch is pushed the entire history gets posted to slack #3

Closed
JamesIry opened this Issue Apr 23, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@JamesIry
  1. Pick an existing stash project with several existing commits.
  2. Configure stash2slack
  3. Create a new branch.
  4. Create one new commit on the new branch.
  5. Push the branch to stash.

Expected: The single new commit is sent to Slack
Actual: The entire history of the project is sent to Slack

@pragbits

This comment has been minimized.

Show comment
Hide comment
@pragbits

pragbits Apr 23, 2015

Owner

Thanks, will check that!

Owner

pragbits commented Apr 23, 2015

Thanks, will check that!

@pragbits

This comment has been minimized.

Show comment
Hide comment
@pragbits

pragbits Apr 24, 2015

Owner

Okay, if the fromHash in the ref change is zero (0000000000000000000000000000000000000000), then this probably means this is a new branch. In this case, I only emit the latest commit to the slack message. As a consequence, if you create a new branch and commit to it more than once before pushing, you will only get the latest commit displayed in the slack message (you can always click on the see commit list link though).

Owner

pragbits commented Apr 24, 2015

Okay, if the fromHash in the ref change is zero (0000000000000000000000000000000000000000), then this probably means this is a new branch. In this case, I only emit the latest commit to the slack message. As a consequence, if you create a new branch and commit to it more than once before pushing, you will only get the latest commit displayed in the slack message (you can always click on the see commit list link though).

@pragbits pragbits self-assigned this Apr 24, 2015

@pragbits pragbits added this to the 1.2 milestone Apr 24, 2015

@pragbits pragbits closed this Apr 24, 2015

@JamesIry

This comment has been minimized.

Show comment
Hide comment
@JamesIry

JamesIry Apr 24, 2015

Thanks! Very fast fix and it works fine.

Thanks! Very fast fix and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment