New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch delete is not informative #4

Closed
JamesIry opened this Issue Apr 23, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@JamesIry
  1. Select a stash project with several branches.
  2. Configure stash2slack
  3. Delete from stash (e.g. git push origin --delete [somebranch])

Expected: an indication that "somebranch" was deleted
Actual: "Push on [repo name] by [author]. See commit list" with no indication of branch delete.

@pragbits

This comment has been minimized.

Show comment
Hide comment
@pragbits

pragbits Apr 24, 2015

Owner

if the branch is deleted via git push origin --delete [branchname] then the following message is generated: {refname} deleted by {username} <{email_address}>.

Owner

pragbits commented Apr 24, 2015

if the branch is deleted via git push origin --delete [branchname] then the following message is generated: {refname} deleted by {username} <{email_address}>.

@pragbits

This comment has been minimized.

Show comment
Hide comment
@pragbits

pragbits Apr 24, 2015

Owner

note that if you delete a branch via the stash web interface no slack message is generated because no push has happened (plugin only subscribed for push and pullreq events)

Owner

pragbits commented Apr 24, 2015

note that if you delete a branch via the stash web interface no slack message is generated because no push has happened (plugin only subscribed for push and pullreq events)

@pragbits pragbits added this to the 1.2 milestone Apr 24, 2015

@pragbits pragbits self-assigned this Apr 24, 2015

@pragbits pragbits closed this Apr 24, 2015

@JamesIry

This comment has been minimized.

Show comment
Hide comment
@JamesIry

JamesIry Apr 24, 2015

Thanks. Very fast fix!

Thanks. Very fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment