Use symbolic icons where appropriate

[TingPing]

You might not agree with this change so I'd like your opnion.The Gnome HIG mentions how the majority of icons should be symbolic icons. They are much cleaner, obvious what they mean, and scale better. I only did the toolbar and playlist area, the file browser should probably use it too. Here is an example of what it looks like:

[JohnDolittle]

(pragha:30297): Gtk-WARNING **: Rescan library: missing action Rescan library

(pragha:30297): Gtk-WARNING **: Update library: missing action Update library

[matiasdelellis]

p.s: Why not replace all the above in a new FILE_LOCAL?
in consonance times it was important to identify between files, but now is irrelevant, and adds many useless comparisons.. 😕

[matiasdelellis]

p.s: Already save around 120mb and still can improve the size using http://www.dependencywalker.com/ But it's a lot of work. Yesterday remove the most obvious and and now missing finer work!. ;)

[matiasdelellis]

Hey,
I like the symbolic icons, but I think it should be a user choice. Some people prefer the colors... (And i also many times use them)

The correct way should be that the user directly select their icons whether symbolic or colored (As always was and he should not have changed!!.), but we could add an option in the "Appearance" tab settings (Simil: "[x] Use symbolic icons in panel")

Maybe doing something like this in the future.

I insist that it should be responsibility of the designers, and therefore I will not change the icons to symbolic mandatory, (SORRY!.) but having the option would be interesting.

Again, leave the bug opened for investigate later. and please follow participating! ;)

Regards,
Matias.

[matiasdelellis]

@TingPing
What do you think?

p.s: The icons in the playlist at least for now prefer to leave with color. ;)

[TingPing]

@matiasdelellis That works, though I think the playlist icons at least should always be symbolic.

[matiasdelellis]

Agree.. You is right in that it is more important, but it may be more difficult do it correctly (Mainly due to change the old error icons.)

[matiasdelellis]

ps.: But not will do it mandatory. There should be better way to do it.
For example, take the information from gtk_style_context_add_class () as the toolbar and the library makes to decorate properly. Icons should do the same, decorated according to the context!

And certainly, this that I am doing not is the best way, but prefer to give the option, rather than follow a strictest rule when I think it is not always are the best way.

p.s2.: The same applies to client-side-decoration. Make it mandatory was a completely erroneous decision.. lot more serious. 😞

[TingPing]

I can understand making the main play buttons an option, the size of them can make symbolic look.. less appealing, but for the playlist it makes absolutely no sense to not use symbolic imo.

[matiasdelellis]

but for the playlist it makes absolutely no sense to not use symbolic imo.

Why? An example?
The reason/pretext of symbolic items use, is display properly the icons in both dark and light themes. But in all tests that I did are displaying properly.
You will find some case, but it is so difficult, then the reasons lose ground. And if necessary, you can change the icon theme, that I think is the right way. In all desktops is thus exept gnome. (Ah. Also in windows. :)

I'll make the change in the playlist. But also optional. 😉

[matiasdelellis]

Heyy..

https://git.gnome.org/browse/gtk+/commit/?h=wip/css-icons&id=ffedaa71cdd4386344d9b1a85c5bc397333ac9a4

We hope that the branch have future. 😄

[TingPing]

@matiasdelellis nice!

[matiasdelellis]

Sorry.
I decided turn back with this change.. Gtk 3.14 will fix the problem as should be..

Or so it seems. Let's wait a bit... 😕

p.s: That mess that is this bug!. Were mixed all comments.. haha. 😅