New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile against PostgreSQL 9.5rc1 #45

Closed
robe2 opened this Issue Dec 25, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@robe2
Contributor

robe2 commented Dec 25, 2015

They broke your code again :)

ogr_fdw.c: In function 'ogr_fdw_handler':
ogr_fdw.c:170:29: warning: assignment from incompatible pointer type [enabled by default]
  fdwroutine->GetForeignPlan = ogrGetForeignPlan;
                             ^
ogr_fdw.c: In function 'ogr_fdw_validator':
ogr_fdw.c:317:30: warning: variable 'layer' set but not used [-Wunused-but-set-variable]
  const char *source = NULL, *layer = NULL, *driver = NULL;
                              ^
ogr_fdw.c: In function 'ogrGetForeignPaths':
ogr_fdw.c:520:6: warning: passing argument 8 of 'create_foreignscan_path' from incompatible pointer type [enabled by default]
      NIL));   /* no fdw_private data */
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: expected 'struct Path *' but argument is of type 'struct List *'
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
ogr_fdw.c:520:6: error: too few arguments to function 'create_foreignscan_path'
      NIL));   /* no fdw_private data */
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: declared here
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
ogr_fdw.c: In function 'ogrGetForeignPlan':
ogr_fdw.c:602:1: error: too few arguments to function 'make_foreignscan'
 );
 ^
In file included from ogr_fdw.h:42:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/planmain.h:46:21: note: declared here
 extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,
                     ^
ogr_fdw.c:605:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
<builtin>: recipe for target `ogr_fdw.o' failed
make: *** [ogr_fdw.o] Error 1
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2  -I/projects/gdal/rel-2.0.1w64gcc48/inclu
ogr_fdw.c: In function 'ogr_fdw_handler':
ogr_fdw.c:170:29: warning: assignment from incompatible pointer type [enabled by default]
  fdwroutine->GetForeignPlan = ogrGetForeignPlan;
                             ^
ogr_fdw.c: In function 'ogr_fdw_validator':
ogr_fdw.c:317:30: warning: variable 'layer' set but not used [-Wunused-but-set-variable]
  const char *source = NULL, *layer = NULL, *driver = NULL;
                              ^
ogr_fdw.c: In function 'ogrGetForeignPaths':
ogr_fdw.c:520:6: warning: passing argument 8 of 'create_foreignscan_path' from incompatible pointer type [enabled by default]
      NIL));   /* no fdw_private data */
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: expected 'struct Path *' but argument is of type 'struct List *'
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
ogr_fdw.c:520:6: error: too few arguments to function 'create_foreignscan_path'
      NIL));   /* no fdw_private data */
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: declared here
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
                     ^
ogr_fdw.c: In function 'ogrGetForeignPlan':
ogr_fdw.c:602:1: error: too few arguments to function 'make_foreignscan'
 );
 ^
In file included from ogr_fdw.h:42:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/planmain.h:46:21: note: declared here
 extern ForeignScan *make_foreignscan(List *qptlist, List *qpqual,
                     ^
ogr_fdw.c:605:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

I noticed the issue after I upgraded to PostgreSQL 9.5rc1 from PostgreSQL 9.5beta2 and my queries with ogrfdw just crashed the backend.

I haven't investigated a fix for this yet.

@robe2

This comment has been minimized.

Show comment
Hide comment
@robe2

robe2 Dec 25, 2015

Contributor

I submitted a pull request #46 . Guess I didn't do it right so it shows automagically here.

Contributor

robe2 commented Dec 25, 2015

I submitted a pull request #46 . Guess I didn't do it right so it shows automagically here.

@robe2

This comment has been minimized.

Show comment
Hide comment
@robe2

robe2 Dec 27, 2015

Contributor

I've got a warning issue to fix. With my new code while it compiles and does work, I get this warning.

ogr_fdw.c: In function 'ogrGetForeignPaths':
ogr_fdw.c:536:6: warning: passing argument 8 of 'create_foreignscan_path' from incompatible pointer type [enabled by default]
      )
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: expected 'struct Path *' but argument is of type 'struct List *'
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,

I'll update my pull request in a bit to get rid of that warning.

Contributor

robe2 commented Dec 27, 2015

I've got a warning issue to fix. With my new code while it compiles and does work, I get this warning.

ogr_fdw.c: In function 'ogrGetForeignPaths':
ogr_fdw.c:536:6: warning: passing argument 8 of 'create_foreignscan_path' from incompatible pointer type [enabled by default]
      )
      ^
In file included from ogr_fdw.h:41:0,
                 from ogr_fdw.c:29:
c:/MING64~1/projects/POSTGR~1/rel/PG9~2.5W6/include/server/optimizer/pathnode.h:82:21: note: expected 'struct Path *' but argument is of type 'struct List *'
 extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,

I'll update my pull request in a bit to get rid of that warning.

@pramsey pramsey closed this Dec 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment