Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies pull request template to include testing details #286

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
3 participants
@bhuvangupta008
Copy link
Contributor

commented Feb 22, 2018

What? Why?

Fix # . (Add Reference to the issue if any)

Changes proposed in this pull request:

  • a
  • b

Checks

  • Single commit and No merge commits
  • Make sure you have added required documentation
  • If you have refactored a code, make sure that you have compared the outputs pre and post refactoring. Add both pre and post refaoring screenshots below if the output is visual

Any images?

Notify reviewers

@kaushik-rohit
@prasadtalasila

@codecov

This comment has been minimized.

Copy link

commented Feb 22, 2018

Codecov Report

Merging #286 into dev will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #286      +/-   ##
=========================================
- Coverage   97.8%   97.31%   -0.49%     
=========================================
  Files         15       15              
  Lines       2230     2237       +7     
=========================================
- Hits        2181     2177       -4     
- Misses        49       60      +11
Impacted Files Coverage Δ
lib/slack/analysis/network.py 95.83% <0%> (-1.88%) ⬇️
lib/analysis/network.py 98.22% <0%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e27354...c04e997. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

commented Feb 22, 2018

Coverage Status

Coverage remained the same at 35.471% when pulling c04e997 on bhuvangupta008:pull-template into 7e27354 on prasadtalasila:dev.

@@ -5,6 +5,9 @@ Changes proposed in this pull request:
- a
- b

##Testing(briefly mention the tests you wrote in regard to the proposed changes)
- Time Period of logs used for testing

This comment has been minimized.

Copy link
@prasadtalasila

prasadtalasila Feb 22, 2018

Owner

@bhuvangupta008 We don't necessarily pass on logs to all the functions.
How about specifying the test input characteristics? If the input is logs, then the characteristic would be: the time period, long length in lines and the file size.
If the input is a graph, then the characteristics would be: number of nodes, number of connections, file size.
If the input is a data structure, then the characteristics would be: number of elements, file size.

Similarly, we can give the characteristics of the output as well.

Feel free to add more items to the description.

@prasadtalasila prasadtalasila added this to In Progress in Testing Feb 26, 2018

@bhuvangupta008 bhuvangupta008 force-pushed the bhuvangupta008:pull-template branch from b5caf37 to c04e997 Feb 26, 2018

@prasadtalasila prasadtalasila merged commit e0ddd54 into prasadtalasila:dev Feb 26, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 35.471%
Details

Testing automation moved this from In Progress to Done Feb 26, 2018

@bhuvangupta008 bhuvangupta008 deleted the bhuvangupta008:pull-template branch Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.