Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Flip Intelligently Functionality #132

Closed
CharoSW opened this issue May 26, 2020 · 5 comments
Closed

Enable Flip Intelligently Functionality #132

CharoSW opened this issue May 26, 2020 · 5 comments
Milestone

Comments

@CharoSW
Copy link

CharoSW commented May 26, 2020

The new toolbar button doesn't use the Smart Direction functionality. Is it possible for that to be implemented or have the ability to scroll to the bottom if the button is clicked and the page is at the top? Additionally, is it possible for the toolbar icon to show which direction such a click might go?

@pratikabu
Copy link
Owner

pratikabu commented May 26, 2020

I can add "Smart Direction" but I felt it will be confusing.

I did implement the "Flip Intelligently" functionality which does exactly detect when to scroll down/top based on page location. I didn't turn it on because currently it doesn't work when you remove the page icon. I'll try to implement it.

image

Changing the icon on the toolbar that frequently might have adverse effect and also require equivalent rotated image to be replaced with. To keep things simple and effective I might not try to implement icon rotation functionality based on the direction. I understand that is not ideal. I'll give it a think later on.

Thanks

@pratikabu
Copy link
Owner

If you currently want the "Flip Intelligently" functionality. Then please run the below javascript in your console window.

$('.settinggroup div.settinglabel:contains("Click Action :")').parent().show()

  1. Open options page of Scroll To Top
  2. Right click on the screen and click "Inspect".
    2.1 image
  3. When the console opens up then go to the "Console" tab.
    3.1 image
  4. On the textarea paste the code that I've shown above and press enter.
  5. You should see a new setting appear on the options page.
    image

Now you can choose click behavior.

Please note: The "Flip Intelligently" functionality only works when the icon is shown on the page as well.

Cheers

@pratikabu
Copy link
Owner

If it is okay I'll reuse this bug to enable Flip Intelligently functionality in the next release? I'll update the title of this bug.

@CharoSW
Copy link
Author

CharoSW commented May 27, 2020

On further thought you are probably right about smart direction being confusing for the toolbar button but the Flip Intelligently works fine for my purposes so that's all good. Feel free to change the title of the bug to track that instead

@pratikabu pratikabu changed the title Have toolbar icon use Smart Direction Enable Flip Intelligently Functionality May 28, 2020
@pratikabu pratikabu added this to the 4.9.1 milestone Jun 4, 2020
@pratikabu
Copy link
Owner

Completed the changes related to enabling flip intelligently functionality.

pratikabu added a commit that referenced this issue Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants