Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unhandled netty errors from stalling writer #4784

Closed
tkaitchuck opened this issue May 12, 2020 · 0 comments · Fixed by #4785 or #4809
Closed

Prevent unhandled netty errors from stalling writer #4784

tkaitchuck opened this issue May 12, 2020 · 0 comments · Fixed by #4785 or #4809
Assignees

Comments

@tkaitchuck
Copy link
Member

Problem description
When appending data to a netty connection a throttle is used to control the rate of transmission. This throttle is released when data is written to the wire successfully of if netty encounters an error and calls into its callback. It is however possible that there could be an error and due to a bug netty fails to catch it and does not invoke the callback.

Problem location
ClientConnectionImpl.java

Suggestions for an improvement
Add a try-catch block around the write call to make sure the callback is invoked upon exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant