Skip to content

PDP-34 Simplified-LTS : Implement background processing for garbage collection of deleted chunks. #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sachin-j-joshi opened this issue Jun 25, 2020 · 0 comments · Fixed by #5413
Closed

PDP-34 Simplified-LTS : Implement background processing for garbage collection of deleted chunks. #4903

sachin-j-joshi opened this issue Jun 25, 2020 · 0 comments · Fixed by #5413
Assignees
@sachin-j-joshi
Labels
area/lts kind/enhancement Improvements that should be made

Comments

@sachin-j-joshi
Copy link
Contributor

Problem description
In current Simplified-LTS implementation attempt is made to delete garbage chunk immediately, however if this fails then warning is logged but that failure is not reattempted in future. This leaves garbage behind.

Problem location
ChunkManager

Suggestions for an improvement

  • Only mark chunks as deleted in metadata.
  • Record list of failed attempt to delete chunks in metadata.
  • Start a background thread, and periodically reattempt the chunk deletion on this background thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachin-j-joshi sachin-j-joshi

Labels
area/lts kind/enhancement Improvements that should be made
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 4903: More robust garbage collection sachin-j-joshi/pravega
1 participant
@sachin-j-joshi