New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutServiceTest fails frequently #716

Closed
tkaitchuck opened this Issue Mar 9, 2017 · 5 comments

Comments

4 participants
@tkaitchuck
Member

tkaitchuck commented Mar 9, 2017

Problem description
TimeoutServiceTest is time dependent and frequently fails.

Problem location
TimeoutServiceTest

Suggestions for an improvement
Use an injected clock so the test is not time dependent.

@bhargav-gulavani

This comment has been minimized.

Collaborator

bhargav-gulavani commented Apr 19, 2017

Never observed a failure on Travis or jenkins or local build.

@Abhijeet-Jadhav

This comment has been minimized.

Collaborator

Abhijeet-Jadhav commented Jun 17, 2017

Observed this, causing local build failure:

io.pravega.controller.timeout.TimeoutServiceTest > testUnknownTxnPingSuccess FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertNotNull(Assert.java:712)
        at org.junit.Assert.assertNotNull(Assert.java:722)
        at io.pravega.controller.timeout.TimeoutServiceTest.testUnknownTxnPingSuccess(TimeoutServiceTest.java:496)
@Abhijeet-Jadhav

This comment has been minimized.

Collaborator

Abhijeet-Jadhav commented Jun 20, 2017

Filed #1455 for the above specific failure.

@Abhijeet-Jadhav

This comment has been minimized.

Collaborator

Abhijeet-Jadhav commented Jun 21, 2017

Observed this, causing local build failure:

io.pravega.controller.timeout.TimeoutServiceTest > testTimeout FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertNotNull(Assert.java:712)
        at org.junit.Assert.assertNotNull(Assert.java:722)
        at io.pravega.controller.timeout.TimeoutServiceTest.testTimeout(TimeoutServiceTest.java:150)
@shiveshr

This comment has been minimized.

Contributor

shiveshr commented Jul 2, 2018

havent observed this in recent times. closing this.

@shiveshr shiveshr closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment