Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2885: Add .nb-gradle to .gitignore #2886

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@eolivelli
Copy link
Collaborator

eolivelli commented Sep 3, 2018

Signed-off-by: Enrico Olivelli eolivelli@apache.org

Change log description
Add Add .nb-gradle to .gitignore

Purpose of the change
Closes #2885

Enrico Olivelli
Issue 2885: Add .nb-gradle to .gitignore
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #2886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2886   +/-   ##
=========================================
  Coverage     78.38%   78.38%           
- Complexity     7192     7193    +1     
=========================================
  Files           545      545           
  Lines         28198    28198           
  Branches       2642     2642           
=========================================
  Hits          22103    22103           
- Misses         4537     4540    +3     
+ Partials       1558     1555    -3
Impacted Files Coverage Δ Complexity Δ
...ntstore/server/host/ZKSegmentContainerManager.java 87.5% <0%> (-6.25%) 6% <0%> (ø)
...egmentstore/server/containers/MetadataCleaner.java 90.56% <0%> (-3.78%) 14% <0%> (-2%)
...eventProcessor/requesthandlers/SealStreamTask.java 87.27% <0%> (-3.64%) 22% <0%> (-1%)
...tore/server/reading/RedirectedReadResultEntry.java 85.24% <0%> (-1.64%) 24% <0%> (-1%)
...ntstore/storage/impl/bookkeeper/BookKeeperLog.java 79.94% <0%> (-1.12%) 78% <0%> (-1%)
...a/segmentstore/server/logs/OperationProcessor.java 84.92% <0%> (-0.74%) 40% <0%> (-1%)
...ga/segmentstore/storage/impl/hdfs/HDFSStorage.java 72.92% <0%> (-0.37%) 51% <0%> (ø)
...o/pravega/client/stream/impl/ReaderGroupState.java 81.81% <0%> (-0.24%) 32% <0%> (ø)
...o/pravega/segmentstore/server/logs/DurableLog.java 89.75% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
.../server/logs/SegmentMetadataUpdateTransaction.java 89.28% <0%> (+0.89%) 83% <0%> (+1%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d7d1e...f608ff1. Read the comment docs.

@fpj
Copy link
Contributor

fpj left a comment

Thanks for the contribution, @eolivelli .

.gitignore Outdated
@@ -18,3 +18,4 @@ out/
.metadata/
.recommenders/
*.log
/.nb-gradle/

This comment has been minimized.

Copy link
@fpj

fpj Sep 5, 2018

Contributor

To be consistent with the other entries, can we just make it .nb-gradle? Also, should we add .nb-gradle-properties?

Enrico Olivelli
add .nb-gradle-properties and fix .nb-gradle pattern
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@eolivelli

This comment has been minimized.

Copy link
Collaborator Author

eolivelli commented Sep 6, 2018

@fpj I have addressed your comments

@fpj

fpj approved these changes Sep 7, 2018

@fpj fpj merged commit 2faa0db into pravega:master Sep 7, 2018

2 checks passed

DCO All commits are signed off!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Aparnarr added a commit to Aparnarr/pravega that referenced this pull request Sep 10, 2018

Issue 2885: Add .nb-gradle to .gitignore (pravega#2886)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>

Aparnarr added a commit to Aparnarr/pravega that referenced this pull request Sep 10, 2018

Issue 2885: Add .nb-gradle to .gitignore (pravega#2886)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.