From 2a438fd67725fc62cea564a50a5f9c6df5f813d7 Mon Sep 17 00:00:00 2001 From: LilSpazJoekp <15524072+LilSpazJoekp@users.noreply.github.com> Date: Mon, 23 Jan 2023 22:05:14 -0600 Subject: [PATCH] Fix removal reason ordering --- praw/models/reddit/removal_reasons.py | 6 ++++-- tests/integration/models/reddit/test_removal_reasons.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/praw/models/reddit/removal_reasons.py b/praw/models/reddit/removal_reasons.py index cfd558063..e4ecf2f52 100644 --- a/praw/models/reddit/removal_reasons.py +++ b/praw/models/reddit/removal_reasons.py @@ -150,8 +150,10 @@ def _removal_reason_list(self) -> List[RemovalReason]: API_PATH["removal_reasons_list"].format(subreddit=self.subreddit) ) return [ - RemovalReason(self._reddit, self.subreddit, _data=reason_data) - for id, reason_data in response["data"].items() + RemovalReason( + self._reddit, self.subreddit, _data=response["data"][reason_id] + ) + for reason_id in response["order"] ] def __getitem__(self, reason_id: Union[str, int, slice]) -> RemovalReason: diff --git a/tests/integration/models/reddit/test_removal_reasons.py b/tests/integration/models/reddit/test_removal_reasons.py index e16fe6b4a..aa81b9a00 100644 --- a/tests/integration/models/reddit/test_removal_reasons.py +++ b/tests/integration/models/reddit/test_removal_reasons.py @@ -54,7 +54,7 @@ def test_update(self, reddit): def test_update_empty(self, reddit): reddit.read_only = False subreddit = reddit.subreddit(pytest.placeholders.test_subreddit) - reason = subreddit.mod.removal_reasons[0] + reason = subreddit.mod.removal_reasons[1] reason.update()