(#1164) Type subreddit.py #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To anyone trying to code review this, read the final file as I had to move the classes in order to not create any more TypeVars |
|
I'm not sure I understand why so many lines were modified. Can you elaborate? |
|
@jarhill0 I shifted all of the methods up from the bottom, so it looks as if every line was deleted and then recreated. This was to not create any more TypeVars |
|
It appears that there is still a merge conflict here. Also, please rebase to avoid using merge commits. |
|
I guess I should copy these over. Making new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base: #1164