[Future] Add support for changes to UserLists on reddit #280

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

andre-d commented Feb 7, 2014

A few UserLists are getting paginated. (http://www.reddit.com/r/redditdev/comments/1x83az/heads_up_important_api_changes/)

Changes will be coming out sometime within the coming week. Putting this here for when the change gets released.

Contributor

Damgaard commented Feb 7, 2014

Awesome! Thanks for that. We should probably work on releasing a new version as soon after the new changes as possible.

Contributor

andre-d commented Feb 19, 2014

These changes have gone out as of now.

Contributor

andre-d commented Feb 19, 2014

I should note that some of these endpoints now 403 instead of 404 when you do not have the proper permissions. Not sure if that breaks any PRAW.

Contributor

Damgaard commented Feb 19, 2014

Looks good. I see a few lines are longer than 80 chars. If you have time to fix that then that would be nice else I can do it myself. Other than that it looks ready to merge.

EDIT: And some endpoints returning 403 instead of 404 shouldn't break anything in PRAW or it's tests.

Contributor

andre-d commented Feb 19, 2014

I think just doc strings I added are over 80, I would be more comfortable if you rearranged those into your common make-this-docstring-better style as I am not familiar with the documentation stye of the rest of the codebase.

Contributor

Damgaard commented Feb 21, 2014

Merged as 52c5c2a.

I made one alteration during the merge which was making _get_user_listing private. It should probably be folded into get_content and we can't easily do that if it's part of the public API.

Thanks a lot for the PR!

@Damgaard Damgaard closed this Feb 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment