Added collapse and uncollapse methods to Message object

[danthedaniel]

These endpoints are currently undocumented, although I have made a PR to have reddit add documentation to their /dev/api page:

reddit-archive/reddit#1365

[voussoir]

You should add these urls to the api paths config in the form seen there. Then you can replace these lines with url = self.reddit_session.config['collapse_message']. Just make sure to keep them alphabetized.

[voussoir]

Thanks for finding this! Should be a quick merge with just those few changes and flake8 fixes.

Oh, also make sure to return the json response, even though it'll probably be an empty dictionary.

[bboe]

It'd be awesome to have tests written for this that utilize the privatemessage scope. Think you're up for giving it a shot?

[danthedaniel]

I can see what I can do, but I won't be able to do that right now.

Also - any reason why it's failing the build tests? It's all running fine on my machine and I didn't change very much.

[voussoir]

It might be passing the betamax tests, but there are some flake8 formatting issues. It says here you've got a blank line with some whitespace characters in it, and it doesn't like your docstrings being split up the way they are.

If you do pip install flake8 and then run flake8 in the main praw folder, it should run over everything and tell you what's wrong. There will be a lot of conf errors and init_test_environment errors that don't matter.

[bboe]

If you open up the p27 test you'll see this information:

0.83s$ flake8 praw
praw/objects.py:710:1: W293 blank line contains whitespace
The command "flake8 praw" exited with 1.
0.57s$ flake8 tests
The command "flake8 tests" exited with 0.
2.03s$ pep257 praw
praw/objects.py:702 in public method `collapse`:
        D202: No blank lines allowed after function docstring (found 1)
praw/objects.py:702 in public method `collapse`:
        D400: First line should end with a period (not 'l')
praw/objects.py:702 in public method `collapse`:
        D200: One-line docstring should fit on one line with quotes (found 3)
praw/objects.py:712 in public method `uncollapse`:
        D202: No blank lines allowed after function docstring (found 1)
praw/objects.py:712 in public method `uncollapse`:
        D400: First line should end with a period (not 'l')
praw/objects.py:712 in public method `uncollapse`:
        D200: One-line docstring should fit on one line with quotes (found 3)

These checks are in place just to help keep things in a consistent manner.

You can run those locally yourself via flake8 praw and pep257 praw. You may need to install those tools to run them: pip install flake8 pep257.

[danthedaniel]

"meat"

[voussoir]

Just one last push, please (unless you want to then write tests afterwards). Can you move the collapse and uncollapse methods so they are below the underscore methods? Then, if you can make it so that uncollapse points to collapse in the same way that unhide points to hide and remove_editor uses add_editor, it would be more stylistically consistent. When you do this, you will need to remove the decorator from uncollapse or else it will fail.

Finally, uncollapse_message needs to be above unfriend as bboe pointed out.

Great changes so far.

[danthedaniel]

Well this is trickier than I'd anticipated, but thanks for all of the help!

[bboe]

Thanks for the PR. I'm going to squash up the commits and merge.

[bboe]

Merged as 0181ac5. Thanks!