Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename variable arr to array, fixes a call to an undefined variable below. #15
@packetmonkey: We're probably missing a test here, and it looks like I may also have missed a spot (in the
I was trying to think through why this wouldn't show up in Prawn's test or manual build, because I know the manual has rotated text, and we have specs that cover that behavior too.
The problem here is basically this: Higher level text methods in Prawn actually use generic matrix transformations to rotate text, whereas this low-level code uses the
To get a reproduction in Prawn, we need to call the
So in summary, we do need a test, either here or in Prawn, ideally in both, and I need to look to see if I missed a spot on the decimal rounding, because that'd be another small bug. We should get this all fixed up and cut a release, but it's less severe than I initially thought because it should only affect these very low-level
@arachnist: If you encountered this error using one of Prawn's higher level APIs, let me know. Otherwise we'll try to get this patched up soonish and cut a release once we do.