Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.2 #1060

Merged
merged 6 commits into from May 5, 2018
Merged

Drop Ruby 2.2 #1060

merged 6 commits into from May 5, 2018

Conversation

pointlessone
Copy link
Member

@pointlessone pointlessone commented Apr 28, 2018

Ruby 2.2 support has ended on March 31. From now on Ruby 2.3 is the minimum required version.

In this PR included:

  • The actual Ruby version changes
  • Code style updates that RuboCop wants for the new target Ruby

This is an informative PR. It will be open for a week and merged on May 5. Community is invited to test it and raise any concerns if there are any.

Ruby 2.2 support has ended on March 31.

https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-2-10-released/

> Ruby 2.2 is under the state of the security maintenance phase, until
> the end of the March of 2018. After the date, maintenance of Ruby 2.2
> will be ended.
This version skips metacomments.
Copy link

@ellcs ellcs left a comment

Looks legit to me!

@pointlessone pointlessone merged commit c504ae4 into master May 5, 2018
2 checks passed
@pointlessone pointlessone deleted the ruby-versions branch May 5, 2018
jessedoyle added a commit to jessedoyle/prawn-icon that referenced this issue May 21, 2018
* Move out shim configuration into a `.yml` file located
  inside the `data/fonts/fa4/shims.yml` file.
* Update FontAwesome TTF files and legend files from 5.0.8
  to 5.0.13.
* Add additional compatibility shims that were missing for
  some icons from FontAwesome 4. This version release is
  now fully backwards-compatible with all icon specifiers
  present in FontAwesome 4 (via version `1.4.0` of this gem).
* Fix a bug in the FontAwesome converter tool by properly
  requiring `fileutils` before execution.
* Remove ruby 2.2.X from the travis build as `prawn` master
  has removed compatibility with this version of Ruby
  (see: prawnpdf/prawn#1060).
* Bump the version of jruby when on the travis builds to
  match prawn master.
* Remove `rbx` from the travis builds. They always error
  and require more time to build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants