Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't wrap by chars if we're going to shrink to fit anyway. #355

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

jcoleman commented Jun 5, 2012

Wrapping by characters seems to be unexpected behavior when the user has specified that the text should be shrunk to fit.

Member

bradediger commented Jun 6, 2012

@Bluejade, thoughts?

Contributor

jcoleman commented Jun 6, 2012

It'd also be nice to support this on text boxes in general, but I think that that's legitimately a separate feature. This one (at least in my mind) is more obvious as it seems more like a bug (or at least unexpected behavior) than a new feature.

Member

Bluejade commented Jun 11, 2012

This would cause text with very long words (eg: URLs) to shrink to the minimum allowed size when :shrink_to_fit was active. :shrink_to_fit is more about fitting vertically, rather than horizontally. There is a single line option that will restrict text boxes to a single line and that should enable shrink_to_fit to work horizontally in that use case.

Contributor

jcoleman commented Jun 11, 2012

Could we perhaps add this as a different option then (like say, :horizontal_shrink_to_fit?)

Perhaps the least invasive and most general purpose route would be to turn your :disable_wrap_by_char option into an explicit user option, rather than an automatic one. I think this was an option way back when, before I rewrote the text box engine.

If you update your patch (please include specs) to take this approach, then that would work for me.

Member

yob commented Dec 8, 2012

Closing this due to a lack of activity. @jcoleman, if you'd like to tweak the patch as suggested by @daniel-nelson then please re-open the pull request.

@yob yob closed this Dec 8, 2012

Contributor

jcoleman commented Feb 28, 2013

@yob: I've updated the patch per @daniel-nelson's suggestion. It doesn't appear that I can re-open the pull request, so I'm going to open a new one and link back to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment