New gradients (alternative API) #408

Merged
merged 2 commits into from Oct 27, 2012

Conversation

Projects
None yet
2 participants
Owner

pointlessone commented Oct 5, 2012

  • Axial gradients (with arbitrary gradient vectors)
  • Radial gradients

This is alternative API to #400. I believe this one is more Prawn-ish. Also code is simpler (as of me) and it handles duplication better that one in #400.

@pointlessone pointlessone New gradients
* Axial gradients (with arbitrary gradient vectors)
* Radial gradients
71f3be8
Owner

pointlessone commented Oct 10, 2012

Are there any concerns to be addressed or is it OK to be merged? I prefer this one over #400 but I'm OK with #400 too functionality wise.

bradediger referenced this pull request Oct 27, 2012

Closed

New gradients #400

Member

bradediger commented Oct 27, 2012

The API and implementation look good, but it would be nice to have a manual page describing and demoing the feature before we merge this. Thanks @cheba!

Owner

pointlessone commented Oct 27, 2012

You wanted manual page for gradients. Would you also like one for soft masks?

bradediger merged commit a68684a into prawnpdf:master Oct 27, 2012

1 check failed

default The Travis build failed
Details
Member

bradediger commented Oct 27, 2012

Man page looks good. Merged, thanks @cheba!

pointlessone referenced this pull request Jan 16, 2013

Closed

Gradient rotation? #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment