New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft hyphens #774

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@practicingruby
Member

practicingruby commented Sep 28, 2014

This is a revised version of #773.

@practicingruby

This comment has been minimized.

Member

practicingruby commented Sep 28, 2014

On the surface this patch looks a lot uglier than #773 (and it is!), but it prevents us from duplicating the process_soft_hyphens method in two different places.

Deeper cleanup is needed down in this code, but I rather make the duplication explicit rather than having two nearly identical methods with slightly different behaviors but no easy way to distinguish between them.

@practicingruby

This comment has been minimized.

Member

practicingruby commented Sep 28, 2014

Merged a squashed version of this in 143371d

@practicingruby

This comment has been minimized.

Member

practicingruby commented Sep 28, 2014

@Mario1988: Because your pull request was accepted, you now have commit access to all prawnpdf repostories. Please see the contribution guidelines here, and thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment