New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for transparency in indexed PNG images #920

Merged
merged 2 commits into from Dec 16, 2015

Conversation

Projects
None yet
4 participants
@pointlessone
Member

pointlessone commented Nov 21, 2015

Solves #783

Here's how palette-8.png (from the supplied test case) looks like in the resulting document.

screen shot 2015-11-21 at 11 12 46 pm

@packetmonkey

This comment has been minimized.

Contributor

packetmonkey commented Nov 22, 2015

Nice! In order to get the test suite passing, do we need to just remove the spec that was ensuring we raised an exception for palleted PNG files? Also I think you left a puts in the specs, we should remove that before merging.

@pointlessone pointlessone force-pushed the pointlessone:alpha-palette branch from ecf0ba3 to 823df34 Nov 22, 2015

@pointlessone

This comment has been minimized.

Member

pointlessone commented Nov 22, 2015

@packetmonkey My bad. Fixed specs, removed puts, and added a Changelog entry.

@pointlessone pointlessone force-pushed the pointlessone:alpha-palette branch from 646f274 to ba8cbc1 Nov 22, 2015

@danielgrippi

This comment has been minimized.

danielgrippi commented Dec 14, 2015

this fixes an issue i've been seeing on my end. when can we expect to see this merged?

@sublimecoder

This comment has been minimized.

sublimecoder commented Dec 15, 2015

This would fix and issue I have. When can this be merged?

packetmonkey added a commit that referenced this pull request Dec 16, 2015

Merge pull request #920 from cheba/alpha-palette
Added support for transparency in indexed PNG images

@packetmonkey packetmonkey merged commit 72b2632 into prawnpdf:master Dec 16, 2015

@packetmonkey

This comment has been minimized.

Contributor

packetmonkey commented Dec 16, 2015

@cheba Strangely master is now broken in Travis, I re-ran the build and it looks still broken after merging this and it bundles locally correctly. Can you check this out to see if we broke something with this PR?

hidakatsuya added a commit to thinreports/thinreports-generator that referenced this pull request Apr 22, 2017

Remove config.convert_palleted_transparency_png option
But PNG images with indexed transparency has been supported by Prawn:
prawnpdf/prawn#920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment