New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTF Support #53

Open
camertron opened this Issue Feb 21, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@camertron
Copy link

camertron commented Feb 21, 2018

Hey there maintainers! I've been working for the last several months on supporting OpenType fonts, which really just means supporting the CFF font table. This is no small task, so the resulting PR was gigantic (git diff --stat tells me 46 files changed, 2990 insertions, 296 deletions). For digestibility I've tried to split it up into bitesized chunks (there are 13 of them) that I will work on submitting as long as you have the patience to review them. The branches have been created off each other in cascading fashion. I will have to submit them as individual pull requests one at a time. The following list serves as a manifest of the branches and should let us track what's been done so far:

I have successfully subsetted several of the Noto and STIX fonts, which I think have been pretty good litmus tests as they are very large and contain good examples of the various CFF sub tables and features. I used an open-source tool called Font-Validator (initially written by the folks at Microsoft) to validate the results.

Please let me know how I can help futher!

This was referenced Feb 21, 2018

@pointlessone

This comment has been minimized.

Copy link
Member

pointlessone commented Feb 21, 2018

@camertron Thank you for your contribution and willingness to undertake this huge effort.

I suspect that these PR are not quite useful in isolation. Do you want me to create a branch off of master so that we could work through all of them without disturbing master in the process and afterwards I'll merge that branch.

@camertron

This comment has been minimized.

Copy link

camertron commented Feb 21, 2018

@pointlessone Yeah, most of them are not useful in isolation. I was thinking of creating pull requests one at a time, but if you're willing to review each branch and merge them into an intermediate branch, that would be awesome! The only thing I'm worried about is where the conversation would happen, since there wouldn't really be a way to comment on individual lines of code.

@pointlessone

This comment has been minimized.

Copy link
Member

pointlessone commented Feb 21, 2018

@camertron I created otf branch. Let's work on that one until all PRs are merged. I'll merge that branch into master when it's done. We'll have discussions in PRs and meanwhile keep master usable.

@camertron

This comment has been minimized.

Copy link

camertron commented Feb 22, 2018

Ok awesome :) I'll change the target of my first pull request to the otf branch.

@camertron

This comment has been minimized.

Copy link

camertron commented May 17, 2018

@pointlessone As I was working on getting the next feature tested and up for review (cff_charset), I ran into a problem. It's very difficult to test the rest of the CFF features individually because they are all connected. I am therefore going to combine the remaining cff_* branches into a single branch called cff_rest and submit it all together.

@pointlessone

This comment has been minimized.

Copy link
Member

pointlessone commented May 17, 2018

@camertron I appreciate your effort to make it easier for me but ultimately there’s no requirement for that so go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment