New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export oneOf spec #49

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@mattbishop
Contributor

mattbishop commented Sep 28, 2017

Fixes #48

@arichiardi

This comment has been minimized.

Show comment
Hide comment
@arichiardi

arichiardi Sep 29, 2017

Collaborator

I wonder if this is one those which we need to insert in the uglify excludes as well. The others are not, so I assume it does not mingle explicitely exported symbols? Opinions?

Collaborator

arichiardi commented Sep 29, 2017

I wonder if this is one those which we need to insert in the uglify excludes as well. The others are not, so I assume it does not mingle explicitely exported symbols? Opinions?

@mattbishop

This comment has been minimized.

Show comment
Hide comment
@mattbishop

mattbishop Sep 29, 2017

Contributor

I have tested this with yarn link in another project and it appears to not need to be uglified.

Contributor

mattbishop commented Sep 29, 2017

I have tested this with yarn link in another project and it appears to not need to be uglified.

@arichiardi arichiardi merged commit 7195d70 into prayerslayer:master Sep 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 89.051%
Details

@mattbishop mattbishop deleted the mattbishop:export-oneOf branch Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment