Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #334. Add .yamlld and .jsonld extensions. #335

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

ioggstream
Copy link
Contributor

This PR

  • adds .yamlld and .jsonld extensions

@asottile
Copy link
Member

asottile commented Oct 4, 2022

these should probably be classified as both their ld equivalents and the base config language as well in case one would want to lint those specifically

@ioggstream
Copy link
Contributor Author

Hi @asottile! I landed here from pre-commit.

  1. The desiderata is that jsonld and yamlld are at least linted with the JSON/yaml linters. It seems that check-yaml skips .yamlld files

  2. It is possible to add further validation (eh using jsonld) JSON schema but it is a complex task to be achieved consistently.

How do you think it is possible to achieve point 1?

Have a nice day!

@asottile
Copy link
Member

asottile commented Oct 5, 2022

your patch does part 1 but you need to address my comment to get merged

@ioggstream
Copy link
Contributor Author

PTAL I "copied" from the xhtml entry. Have a nice day, R.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 4660ca5 into pre-commit:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants