Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang extensions and files #340

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

sebastiw
Copy link
Contributor

Most common extensions for Erlang
I also included a configuration file rebar.config for one of the most common compilers. The other files included are sys.config specifying the released applications configuration and sys.config.src for the pre-released version.

identify/extensions.py Outdated Show resolved Hide resolved
@@ -78,6 +80,7 @@
'hcl': {'text', 'hcl'},
'hh': {'text', 'header', 'c++'},
'hpp': {'text', 'header', 'c++'},
'hrl': {'text', 'header', 'erlang'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while the current header tag isn't great -- I think it kinda means C-like headers so this would break tools expecting those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure what you mean. Erlang header files usually contain macros shared between source files. Do you have an example on how it's used in c?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's that it's already used for c likes so reusing the tag for erlang would break existing things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, ok. I've removed 'header' for now, let's see how it works and in worst case I'll add a 'header_erlang' tag or something then.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 916360d into pre-commit:main Nov 18, 2022
@sebastiw sebastiw deleted the add-erlang branch November 18, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants