Add ppm file to extensions #352
Conversation
identify/extensions.py
Outdated
| @@ -163,6 +163,7 @@ | |||
| 'png': {'binary', 'image', 'png'}, | |||
| 'po': {'text', 'pofile'}, | |||
| 'pp': {'text', 'puppet'}, | |||
| 'ppm': {'binary', 'image', 'ppm'}, | |||
There was a problem hiding this comment.
the point of ppm is it's not binary https://anthonysottile.com/ppm/
There was a problem hiding this comment.
As I look more, it's actually conditional. The magic number at the beginning of the file indicates if it should be parsed as ASCII or binary, so I guess we can't really make this kind of assertion based on extension alone, unfortunately. Is there somewhere in the existing flow that this type of check would be supported? The linux file utility, for example, can correctly identify a binary example, like this:
frame-40.ppm: Netpbm image data, size = 1920 x 1080, rawbits, pixmap
There was a problem hiding this comment.
identify/identify/extensions.py
Line 268 in eb54678
There was a problem hiding this comment.
Updated. Please let me know if there's somewhere else that also needs updating.
PPM is portable pixmap format
PPM is portable pixmap format