Skip to content

Conversation

@janosh
Copy link
Contributor

@janosh janosh commented Oct 23, 2021

No description provided.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to do the SystemExit thing with all-repos so you don't need to do that here

README.md Outdated
Some out-of-the-box hooks for pre-commit.

See also: https://github.com/pre-commit/pre-commit
See also: <https://github.com/pre-commit/pre-commit>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no improvement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually. On GitHub, this is identical. But some markdown parsers that follow the original spec don't convert URLs to clickable links unless enclosed in angle brackets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're on github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People clone repos and view files locally... but of course up to you.

README.md Outdated

#### `no-commit-to-branch`
Protect specific branches from direct checkins.
Protect specific branches from direct check-ins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a typo

README.md Outdated
Checks that all your JSON files are pretty. "Pretty"
here means that keys are sorted and indented. You can configure this with
the following commandline options:
the following command line options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen it in one word before always two words or dash. https://wikipedia.org/wiki/Command-line_interface

README.md Outdated
- `--indent ...` - Control the indentation (either a number for a number of spaces or a string of whitespace). Defaults to 2 spaces.
- `--no-ensure-ascii` preserve unicode characters instead of converting to escape sequences
- `--no-sort-keys` - when autofixing, retain the original key ordering (instead of sorting the keys)
- `--no-sort-keys` - when auto-fixing, retain the original key ordering (instead of sorting the keys)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a typo

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 9fc352b into pre-commit:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants